Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36749][state/forst] Implement rescaling for ForStStateBackend #25676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-36749][state/forst] Implement rescaling for ForStStateBackend #25676

wants to merge 1 commit into from

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Nov 22, 2024

What is the purpose of the change

This PR implements rescaling for ForStStateBackend. The optimization of IngestDB + clipDB is also availiable.

Brief change log

  • Support iterate + insert rescaling in ForStIncrementalRestoreOperation.
  • Support IngestDB + deleteRange rescaling in ForStIncrementalRestoreOperation.

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

This change added tests and can be verified as follows:

  • Enable ForStStateBackendTest
  • Add ForStIncrementalCheckpointRescalingTest for ForStSyncKeyedStateBackend.
  • Add StateBackendTestV2Base#testAsyncStateBackendScaleUp and StateBackendTestV2Base#testAsyncStateBackendScaleDown for ForStKeyedStateBackend

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 22, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

davidradl
davidradl reviewed Nov 28, 2024
View reviewed changes
flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/StateBackendTestV2Base.java
numberOfKeyGroups,
new KeyGroupRange(0, numberOfKeyGroups - 1),
keyGroupRange.getNumberOfKeyGroups(),
keyGroupRange,
Copy link

@davidradl davidradl Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need both parameters - if one can be derived from another?

@davidradl
Copy link

Reviewed by Chi on 28/11/24. Asked submitter questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl left review comments

Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredia @flinkbot @davidradl